httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: cvs commit: apache-1.3/src/main http_main.c
Date Thu, 04 Oct 2001 12:19:10 GMT
jim@apache.org wrote:
> 
>   -static void accept_mutex_init_tpfcore(pool *foo)
>   -{
>   -}
>   +#define accept_mutex_init_tpfcore(x)
>    
>    static void accept_mutex_child_init_tpfcore(pool *p)
>    {
>   @@ -1100,7 +1098,7 @@
>    
>    accept_mutex_methods_s accept_mutex_tpfcore_s = {
>        accept_mutex_child_init_tpfcore,
>   -    accept_mutex_init_tpfcore,
>   +    NULL,
>        accept_mutex_on_tpfcore,
>        accept_mutex_off_tpfcore,
>        "tpfcore"
>   

Ideally, what I should have done in the 1st place is:

	#define accept_mutex_foo_bar NULL

for those nop's that way we would have avoided the above, and all the
structures would be semi-consistant, rather than a mix of real
functions and NULLs... I never documented that those mutex functions that
were null defines mapped to NULL entries in the struct... Worth holding
off 1.3.21 for this??

-- 
===========================================================================
   Jim Jagielski   [|]   jim@jaguNET.com   [|]   http://www.jaguNET.com/
      "A society that will trade a little liberty for a little order
                   will lose both and deserve neither"

Mime
View raw message