httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@covalent.net>
Subject Re: [PATCH] Apache 1.3 ApacheCore.imp ApacheCore.def
Date Sun, 07 Oct 2001 04:47:42 GMT
From: "Thomas Eibner" <thomas@stderr.net>
Sent: Saturday, October 06, 2001 6:17 PM


> On Sat, Oct 06, 2001 at 05:36:49PM -0500, William A. Rowe, Jr. wrote:
> > Win32 also needs the appropriate API_EXPORT macros around the 
> > prototype and declaration of ap_update_vhost_from_headers.
> 
> Like the attached patches?

Bingo :)

> > I don't know that I have any other objections to exporting
> > ap_update_vhost_from_headers.  There are actually several symbols
> > in support/httpd.exp that might be added.  I tend to believe we
> > aught to simply any missing items from list (with appropriate 
> > API_EXPORTs.) 
> 
> Want me to supply a similar patch for the missing items from the list?

With the caviat --- we won't reexport symbols present in the other 
libraries [the users can always bind to expat or regex directly.]

Sure :)  If you can consistify the netware's .imp and win32's .def
to that httpd list, that would be very cool.  I'd just apply the entire
list at once, so please don't change anything other than that list of
symbols.

Don't forget to declare them appropriately.  If they use non-std args,
e.g. (int foo, ...) then we need to declare them API_EXPORT_NONSTD.
Data is also a bit different.  Since you created the patch, I presume
you already know these things.

No sense in having platforms with mismatching exports.

Bill



Mime
View raw message