Return-Path: Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 85046 invoked by uid 500); 10 Sep 2001 05:38:06 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 85035 invoked from network); 10 Sep 2001 05:38:06 -0000 X-Authentication-Warning: cobra.cs.Virginia.EDU: jcw5q owned process doing -bs Date: Mon, 10 Sep 2001 01:38:14 -0400 (EDT) From: Cliff Woolley X-X-Sender: To: Subject: Re: [PATCH] performance patch for mod_log_config In-Reply-To: <3B9C4A5A.4070209@pacbell.net> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On Sun, 9 Sep 2001, Brian Pane wrote: > I think putting it in APR would work. The one limitation I can think of > is that adding the cache in apr_explode_localtime() itself wouldn't be a > win because we'd have to add the overhead of a gettimeofday() call to > check whether the supplied time was indeed current (and thus susceptible > to caching). It took me a minute to figure out why this was a problem, but you're right. I don't really like the idea of combining time_now and explode_localtime, though. What about some kind of deal like apr_explode_recent_localtime() which is the same as apr_explode_localtime() except that the input must never be older than TIME_CACHE_SIZE seconds? Or is that too httpd-tailored? If so, no sweat, make it an ap_ function instead of an apr_ function. --Cliff -------------------------------------------------------------- Cliff Woolley cliffwoolley@yahoo.com Charlottesville, VA