Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Date: Sun, 30 Sep 2001 02:20:30 -0700
From: Aaron Bannert <aaron@clove.org>
To: dev@httpd.apache.org
Subject: Re: cvs commit: httpd-2.0/support config.m4
Message-ID: <20010930022030.L7447@clove.org>
References: <20010930075715.11462.qmail@icarus.apache.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <20010930075715.11462.qmail@icarus.apache.org>;
 from jerenkrantz@apache.org on Sun, Sep 30, 2001 at 07:57:15AM -0000

On Sun, Sep 30, 2001 at 07:57:15AM -0000, jerenkrantz@apache.org wrote:
> jerenkrantz    01/09/30 00:57:15
> 
>   Modified:    .        acinclude.m4 configure.in CHANGES
>                modules  config5.m4
>                server/mpm config.m4
>                support  config.m4
>   Log:
>   Kill two autoconf-related birds with one commit.
>   
>   - substr used in APACHE_MODULE for the help string did not parse correctly
>     with autoconf 2.50+ so we had to punt there anyway and use AC_HELP_STRING.
>   - Add APACHE_HELP_STRING define that will call AC_HELP_STRING on 2.50+
>     (actually not 2.13 - look at the regex call) or do our custom variation
>     of it.  This function can't have any extra spaces or it will be returned
>     in the help string.  So noted.  If anyone can figure out how to insert
>     a line break like 2.50+ does when we go over the 26th column, I'd
>     appreciate it.  I tried and I'm way too tired to figure it out now.
>     Adding this would greatly simplify two or three HELP_STRING uses.
>   - Switch all of those annoying WITH and ENABLE functions to use the
>     APACHE_HELP_STRING.  This makes everything consistent now.  I've always
>     had to go through and keep aligning everything every few months or so
>     because I'm the only one who cares.  No more.  I refuse to do it any more!
>     Use APACHE_HELP_STRING or be crucified.

Looks good from here (autoconf 2.13) with one minor complaint: I'm seeing
things like this from --help for long parameters:

  --enable-optional-hook-export example optional hook exporter
                              ^^^

Any way we can make it put an extra space in there like we used to have,
just to make it more readable? Just count how long the parameter string
length is and add an extra space to the help string if over some constant.
I'd do it but I'm no m4 guru. :)

-aaron