Return-Path: Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 12725 invoked by uid 500); 6 Sep 2001 14:51:40 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 12699 invoked from network); 6 Sep 2001 14:51:39 -0000 Content-Type: text/plain; charset="iso-8859-1" From: Ryan Bloom Reply-To: rbb@covalent.net Organization: Covalent Technologies To: dev@httpd.apache.org, Cliff Woolley Subject: Re: [PATCH] Take 3 of mod_include patch... Date: Thu, 6 Sep 2001 07:52:25 -0700 X-Mailer: KMail [version 1.3] References: In-Reply-To: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-Id: <20010906145226.2975246DF4@koj.rkbloom.net> X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On Wednesday 05 September 2001 20:24, Cliff Woolley wrote: > On Wed, 5 Sep 2001, john sachs wrote: > > i applied this patch and the mod_include test fails in the same spot > > as it has been. content file has: > > > > 'include file' with relative path to file not in same path as the file > > you are requesting. > > Yep. This patch has no effect on that. It's probably not mod_include > that needs patching, but rather the core. I was hoping OtherBill could > enlighten us on what the Right Way to fix it is... because I have very > little idea myself. > > Last I heard, Bill suggested we just set r->uri=NULL in that case and just > test for (r->uri) in all places we use r->uri, rather than setting r->uri > to some bogus string. I'm all for it, if we're convinced that that's the > right thing to do. I'll take a stab at patching it that way tomorrow just > for grins. I actually hit this same seg fault in mod_jk late last night. If mod_include is changed to fix this, then we are most likely doing it wrong, and I will veto that. The first step is to set r->uri to NULL if it is INTERNALLY GENERATED. Then, we have to figure out where that is seg faulting, and fix that location. I have some big problems with the way that location walk and directory walk work now, BTW, because if I write a module that doesn't get pages from the filesystem, I have to catch those in the map_to_storage hook, or the server will 500. Ryan ______________________________________________________________ Ryan Bloom rbb@apache.org Covalent Technologies rbb@covalent.net --------------------------------------------------------------