Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Date: Tue, 4 Sep 2001 19:15:03 -0700
From: Greg Stein <gstein@lyra.org>
To: dev@httpd.apache.org
Subject: patch comments Re: [PATCH] Add mod_gz to httpd-2.0
Message-ID: <20010904191503.O9504@lyra.org>
References: <20010901145645.W10838@ebuilt.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2i
In-Reply-To: <20010901145645.W10838@ebuilt.com>;
 from jerenkrantz@ebuilt.com on Sat, Sep 01, 2001 at 02:56:45PM -0700

On Sat, Sep 01, 2001 at 02:56:45PM -0700, Justin Erenkrantz wrote:
>...
> I told him I'd look at it a while ago, but never got a chance to do 
> so.  So, I spent this morning cleaning up the configuration and a bit 
> of the code to fit our style (nothing major).

You shouldn't have to do that. Ian should, and he must learn to deal with it
if he wants to continue contributing. We all learn different habits to work
in this group.

> I'd like to add this to the modules/filters directory (which seems
> like the most appropriate place).

Yes.

>...
> We could remove GZFilter as it really serves no purpose as well as the 
> text/html check in mod_gz.

s/could/should/

I agree that it doesn't make sense to be in there. We should be using more
consistent mechanism to handle filter inclusion and management. One-off
commands here and there are simply serving to make the filter system more
complicated.

> I'd like to commit something that is close
> to what Ian originally submitted and then tweak it slightly.

Push it back to him to tweak. It appears we have a bit of time :-)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/