Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Subject: Re: Tag time?
From: Ian Holsman <IanH@cnet.com>
To: dev@httpd.apache.org
In-Reply-To: <20010916133438.S12417@ebuilt.com>
References: <20010916133438.S12417@ebuilt.com>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Date: 16 Sep 2001 13:49:12 -0700
Message-Id: <1000673352.2827.3.camel@c1619481-a.almda1.sfba.home.com>
Mime-Version: 1.0

On Sun, 2001-09-16 at 13:34, Justin Erenkrantz wrote:
> Not that I volunteer to be RM or anything, but any reason why we
> couldn't try to get a beta out this week?  -- justin

The mod-include patch should be reviewed and/or committed.
(included here)
The jist of the pach.. 
we can't compute ETag/Last-Modified on the SSI file
as we don't have enough info at the start of the file.

I'd also log to see the mod_log_config patch  (caching time() calls)
and the removal of r->notes (both by brianp) in there. the second is
important, as it is a change of API, and should be done before a beta.

Aaron also has some worker MPM patches I'm benchmarking at the moment.


Index: mod_include.c
===================================================================
RCS file: /home/cvspublic/httpd-2.0/modules/filters/mod_include.c,v
retrieving revision 1.146
diff -u -u -r1.146 mod_include.c
--- mod_include.c       2001/09/10 03:58:26     1.146
+++ mod_include.c       2001/09/14 19:34:17
@@ -3081,6 +3081,13 @@
      * the content-length should just be unset.
      */
     apr_table_unset(f->r->headers_out, "Content-Length");
+    /*
+     * Always unset the ETag/Last-Modified fields.
+     * We don't know if we are going to be modified after we have
+     * sent the headers out.
+     */
+    apr_table_unset(f->r->headers_out, "ETag");
+    apr_table_unset(f->r->headers_out, "Last-Modified");

     rv = send_parsed_content(&b, r, f);

-- 
Ian Holsman
Performance Measurement & Analysis
CNET Networks    -    415 364-8608