httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cliff Woolley <cliffwool...@yahoo.com>
Subject Re: [PATCH] performance patch for mod_log_config
Date Mon, 10 Sep 2001 05:06:06 GMT
On Sun, 9 Sep 2001, William A. Rowe, Jr. wrote:

> Is this the right place to be caching, or should this become a
> straightforward optimization to apr's time.c functions?  I'd think the
> advantages are many for keeping 15 current seconds in apr, and would
> pay off across the board.  Within apr, we can always recalculate just
> the ms as well, for fun.

+1

On a side note, I was doing a grep through the server for
apr_explode_localtime() to see where all it was used and came across this
hideously expensive-looking if/elseif/elseif/.../elseif/else block in
mod_rewrite for variable substitution.  Surely there's a faster way to
accomplish that little bit of logic than forty or so strcasecmp's for each
variable (in the worst case)...

--Cliff

--------------------------------------------------------------
   Cliff Woolley
   cliffwoolley@yahoo.com
   Charlottesville, VA



Mime
View raw message