httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mladen Turk" <mladen.t...@mail.inet.hr>
Subject [PATCH] WIN9x shutdown/logoff -- Win9xConHook
Date Sun, 09 Sep 2001 17:34:16 GMT
Hi all,

There has been some thoughts to "adopt" the Win9xConHook from 1.3 branch. I
even posted the patch last month and Bill already put the Win9xConHook to
CVS.

Now, I have some doubts if this is the right way to go, and here is why:
Apache2 already has a service monitor thread (monitor_service_9x_thread),
but the problem with it is that it is called prior the
mpm_start_child_control_handler and IMO that is why the console window stays
open.

The other thing I can't figure out is why the winnt_post_config hook is
called twice?

The patch only calls FreeConsole and the logoff and shutdown events are
handled without nasty "Could Close APACHE" message.


--- server/mpm/winnt/service.c.old	Sun Sep  9 19:09:42 2001
+++ server/mpm/winnt/service.c	Sun Sep  9 19:09:52 2001
@@ -364,6 +364,7 @@
     }
     else
     {
+        FreeConsole();
         SetConsoleCtrlHandler(child_control_handler, TRUE);
         atexit(stop_child_console_handler);
     }


Now, IMO there is no need for Win9xConHook because monitor_service_9x_proc
already handles that.

MT.


Mime
View raw message