httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Ames <grega...@remulak.net>
Subject [PATCH] autoindex instead of index.html
Date Wed, 26 Sep 2001 20:44:59 GMT
Greg Ames wrote:
> 
> Ryan Bloom wrote:
> >
> > On Tuesday 25 September 2001 03:32 pm, Greg Ames wrote:
> >
> > Yeah, that should fail.  Why isn't that an absolute path?
> 
> That's the bug.  We're not mapping the subrequest URI into a path in
> this case.  

OK, this takes care of it.  mod_rewrite's translation phase
(hook_uri2file) uses r->filename all over the place, and leaves it set
even if no rules apply.  A recent change to ap_core_translate  bails out
if it's a subrequest and r->filename is already set.  I don't know what
the intention of this change was, and I don't plan on rewriting
mod_rewrite, but I will test this little patch more thoroughly.

Greg

Index: server/core.c
===================================================================
RCS file: /cvs/apache/httpd-2.0/server/core.c,v
retrieving revision 1.61
diff -u -d -b -r1.61 core.c
--- core.c      2001/09/19 05:52:42     1.61
+++ core.c      2001/09/26 20:44:48
@@ -2555,8 +2555,6 @@
     /* XXX We have already been here, or another module did the work
      * for us.  At this moment, we will enable only file subrequests.
      */
-    if (r->main && r->filename)
-        return OK;
 
     /* XXX this seems too specific, this should probably become
      * some general-case test

Mime
View raw message