httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pavel Novy <n...@feld.cvut.cz>
Subject Re: [PATCH] Apache 1.3 - mod_auth etc.
Date Wed, 12 Sep 2001 16:01:04 GMT
Hi,

William A. Rowe, Jr. wrote:
 > From: "Pavel Novy" <novy@feld.cvut.cz>
 > Sent: Wednesday, September 12, 2001 9:55 AM
 >
 >
 >
 >>Hi all,
 >>
 >>after last changes in a src/modules/standard/mod_auth.c file it is
 >>impossible to compile the Apache core for NetWare platform. I can't
 >>understand why these changes have been commited untested. Patch
 >>attached. Thanks.
 >>
 >
 > That's fine - applied.  I expect OS2 needs this patch as well?

Sorry, I'm not familiar with OS/2 port.

 >
 >>P.S.: The second try with my older (gcc related) proposed updates in
 >>src/include/util_uri.h and src/os/netware/os.h files. Attached.
 >>
 >
 > Comments follow;
 >
 >
 >>--- src/os/netware/os.h Wed Aug 22 00:12:00 2001
 >>+++ src_gcc/os/netware/os.h Sun Sep  2 02:23:36 2001
 >>@@ -136,7 +136,7 @@
 >> void AMCSocketCleanup(void);
 >> void clean_parent_exit(int code);
 >>
 >>-inline int ap_os_is_path_absolute(const char *file)
 >>+static inline int ap_os_is_path_absolute(const char *file)
 >>
 >
 > Aren't there some compilers with serious problems about static and 
inline being
 > mutually exclusive???  I would suspect inline is sufficient here for 
all Netware
 > compilers, no?

Basically, it's impossible to link Apache core for NetWare with GNU
stuff due duplicate symbol produced in all object files generated from
sources with "#include <os.h>". It looks like gcc related issue (the
same behaviour on Linux) - I've attached a simple sample demonstrating
this issue in some of my older postings, but didn't get no response
here. Sorry, but I'm still not too familiar with the GNU (gcc) stuff to
resolve the issue. Take a look on attached sample, if you are
interested, please.

 >
 >>--- util_uri.h.orig Mon Feb 26 16:49:32 2001
 >>+++ util_uri.h Mon Aug 27 15:44:41 2001
 >>@@ -106,10 +106,10 @@
 >>
 >>     unsigned short port; /* The port number, numeric, valid only if 
port_str != NULL */
 >>
 >>-    unsigned is_initialized:1;
 >>+    unsigned char is_initialized:1;
 >>
 >>-    unsigned dns_looked_up:1;
 >>-    unsigned dns_resolved:1;
 >>+    unsigned char dns_looked_up:1;
 >>+    unsigned char dns_resolved:1;
 >>
 >> } uri_components;
 >>
 >
 > Out of the question.  If I didn't say so before, I explicitly veto 
this solution.
 > EVERYBODY has this problem.  Solaris, HP, etc _all_ are binary 
incompatable with
 > gcc results.
 >
 > Apache 2.0 -should- strive to resolve these, when we can.  But we 
aren't breaking
 > binary compatibility for one platform in the 1.3 series with a 
non-standard, and
 > possibily incompatible fix.  For that matter, this patch may even 
*break* compatibility
 > between different big-endian compilers.  It's not worth rolling the dice.

Okay, I am definitively giving it up. I hope that these strange
compatibility issues will not appear in 2.0 - I suggest to not use the
bitfields anymore.

 > Bill
 >

Thanks for your response.

Regards,
Pavel

Mime
View raw message