httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Pane <bp...@pacbell.net>
Subject [PATCH 3] performance patch for mod_log_config
Date Tue, 11 Sep 2001 01:00:06 GMT
Here's an updated version of the patch that fixes the
race condition that Dean pointed out involving requests
that last almost exactly 15 seconds.  The comments in
the code describe the "snapshot" technique that it uses
to detect and correct the race condition.

--Brian

Index: modules/loggers/mod_log_config.c
===================================================================
RCS file: /home/cvspublic/httpd-2.0/modules/loggers/mod_log_config.c,v
retrieving revision 1.68
diff -u -r1.68 mod_log_config.c
--- modules/loggers/mod_log_config.c    2001/08/27 20:50:01    1.68
+++ modules/loggers/mod_log_config.c    2001/09/11 00:47:58
@@ -463,9 +463,9 @@
     a problem with this, you can set the define.  -djg
     */
 #ifdef I_INSIST_ON_EXTRA_CYCLES_FOR_CLF_COMPLIANCE
-    apr_explode_localtime(&xt, apr_time_now());
+    ap_explode_recent_localtime(&xt, apr_time_now());
 #else
-    apr_explode_localtime(&xt, r->request_time);
+    ap_explode_recent_localtime(&xt, r->request_time);
 #endif
     if (a && *a) {              /* Custom format */
         apr_strftime(tstr, &retcode, MAX_STRING_LEN, a, &xt);




Mime
View raw message