httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Pane <bp...@pacbell.net>
Subject Re: [PATCH] optimization for setting of allowed methods
Date Thu, 06 Sep 2001 21:33:00 GMT
Ryan Bloom wrote:

>On Thursday 06 September 2001 09:29, Greg Marr wrote:
>
>>At 11:50 AM 09/06/2001, Brian Pane wrote:
>>
>>>This patch eliminates some run-time conversion of method names to
>>>numbers (something that I noticed while looking through function
>>>call profiles).
>>>
>>>RCS file: /home/cvspublic/httpd-2.0/server/core.c,v
>>>-    ap_allow_methods(r, MERGE_ALLOW, "GET", "OPTIONS", "POST", NULL);
>>>+    ap_allow_standard_methods(r, MERGE_ALLOW, M_GET, M_OPTIONS,
>>>M_POST, -1);
>>>
>>>RCS file:
>>>/home/cvspublic/httpd-2.0/modules/mappers/mod_negotiation.c,v
>>>-    ap_allow_methods(r, REPLACE_ALLOW, "GET", "OPTIONS", "POST",
>>>NULL);
>>>+    ap_allow_standard_methods(r, REPLACE_ALLOW, M_GET, M_OPTIONS,
>>>M_POST, -1);
>>>
>>Weren't these "method numbers" recently removed so that there are no
>>"standard" methods, and all the methods are added the same way at run
>>time?
>>
>
>Nope.  In order to keep backwards compat, keep the patch small, and keep the
>performance high for the standard HTTP methods, the old macros were kept.
>We just register them the same way we register extensions (they are gauranteed
>to have the same value as the constant though).
>
Cool.  Anybody willing to commit the patch?

Thanks,
--Brian




Mime
View raw message