httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ian Holsman <i...@cnet.com>
Subject Re: [PATCH] Take 3 of mod_include patch...
Date Thu, 06 Sep 2001 02:22:44 GMT
john sachs wrote:

> i applied this patch and the mod_include test fails in the same spot as it has been.
> content file has:
> <!--#include file="extra/inc-extra1.shtml"-->+


Hi John.
This patch was not intended to fix this problem,
it was intended to speed up the 'finding' of the '<!--#' tag
itself.
errors you might find due to this patch is that some SSI tags are not
getting evaluated (with the SSI tag stil in the output)

a couple of testcase would be something like
handling a string "<!--#--><!--#x-->"
or "<<!--#"
..Ian


> 
> 'include file' with relative path to file not in same path as the file you are requesting.
> 
> causes segv.  here is stacktrace:
> 
> #0  0x80c4056 in ap_getparents (
>     name=0x816a840 "INTERNALLY GENERATED file-relative req") at util.c:488
> #1  0x80d327f in ap_process_request_internal (r=0x82720e4) at request.c:152
> #2  0x80d4bd6 in ap_sub_req_lookup_file (
>     new_file=0xbfffafc4 "extra/inc-extra1.shtml", r=0x8277194,
>     next_filter=0x8278294) at request.c:1688
> #3  0x807718f in handle_include (ctx=0x826d054, bb=0xbfffd470, r=0x8277194,
>     f=0x827826c, head_ptr=0x8277128, inserted_head=0xbfffd40c)
>     at mod_include.c:1033
> #4  0x807b182 in send_parsed_content (bb=0xbfffd470, r=0x8277194, f=0x827826c)
>     at mod_include.c:2840
> #5  0x807bb32 in includes_filter (f=0x827826c, b=0x82783f4)
>     at mod_include.c:3081
> #6  0x80c9db4 in ap_pass_brigade (next=0x827826c, bb=0x82783f4)
>     at util_filter.c:275
> #7  0x80d1b9b in default_handler (r=0x8277194) at core.c:3068
> #8  0x80bd501 in ap_run_handler (r=0x8277194) at config.c:185
> #9  0x80bdbcf in ap_invoke_handler (r=0x8277194) at config.c:344
> #10 0x80958b1 in ap_process_request (r=0x8277194) at http_request.c:286
> #11 0x80907e8 in ap_process_http_connection (c=0x820c3ac) at http_core.c:287
> #12 0x80c8015 in ap_run_process_connection (c=0x820c3ac) at connection.c:82
> #13 0x80c8240 in ap_process_connection (c=0x820c3ac) at connection.c:219
> #14 0x80bc03c in child_main (child_num_arg=0) at prefork.c:829
> #15 0x80bc19d in make_child (s=0x8196f4c, slot=0) at prefork.c:916
> #16 0x80bc223 in startup_children (number_to_start=1) at prefork.c:939
> #17 0x80bc6ce in ap_mpm_run (_pconf=0x8195804, plog=0x81cd9c4, s=0x8196f4c)
>     at prefork.c:1155
> #18 0x80c20bc in main (argc=6, argv=0xbffff664) at main.c:431
> #19 0x40105577 in __libc_start_main () from /lib/libc.so.6
> 
> -j
> 




Mime
View raw message