httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <jerenkra...@ebuilt.com>
Subject Re: [PATCH] Take 3 of httpd filter rewrite...
Date Sat, 29 Sep 2001 05:01:10 GMT
On Fri, Sep 28, 2001 at 09:29:32PM -0700, Ryan Bloom wrote:
> I agree with Greg that creating this socket bucket isn't necessary.  This filter
> should just read from the network.

That's a bit more than I'm comfortable doing right now.  We can certainly
add this once it gets committed.  It shouldn't change the logic
substantially.

> > +        apr_brigade_partition(ctx->b, *readbytes, &e);
> > +        /* Must do split before CONCAT */
> > +        if (e != APR_BRIGADE_SENTINEL(ctx->b)) {
> > +            newbb = apr_brigade_split(ctx->b, e);
> > +        }
> > +        APR_BRIGADE_CONCAT(b, ctx->b);
> 
> I'm assuming this has been removed since this patch was posted.

Yes, it has.  =-)

> Looks good to me.  I would prefer it if this wasn't committed until the server
> was working correctly again, because that would make debugging any bugs
> that are introduced much easier.  But, I am NOT even asking for that delay.

Thanks - I know you are very busy.  =)

Yeah, I know.  I'm going to start looking at what the heck happened
with the current code and see if I can track this down.  I know that 
I'm not crazy now - jsachs said he sees it too.

Once the server is stable, I'll commit this patch as posted and
then follow up shortly thereafter with the commits for comments and 
then another one for the ap_getline changes.  I also have an idea
on how to delay the insertion of the HTTP_IN filter until after
we know we have a valid HTTP request.  These are tested, but I'd
rather make them distinct commits than doing it all at once.
-- justin


Mime
View raw message