httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ryan Bloom <...@covalent.net>
Subject Re: [PATCH] Take 2 of the http filter rewrite
Date Mon, 24 Sep 2001 19:45:19 GMT
On Monday 24 September 2001 12:27 pm, Justin Erenkrantz wrote:
> On Mon, Sep 24, 2001 at 03:14:22PM -0400, Cliff Woolley wrote:
> > On Mon, 24 Sep 2001, Justin Erenkrantz wrote:
> > > The brigades should not be returning more data than is asked for
> > > ever.
> >
> > Right.  But the only increment the API allows to ask for are one whole
> > bucket's worth at a time.
>
> util_filter's ap_get_brigade takes in the length to read.  The
> translation from httpd->apr_util in the core filter loses this
> distinction.  The core filter should be splitting the buckets and
> only returning the requested amount to HTTP_IN (and it'd have to
> handle the 0 case when we want to read a line).  Since the
> core is inherently connection-based, I see no reason why the
> buffering can't be done there.  Currently, it passes the
> socket bucket up the chain.
>

The original reason that the core worked this way, was to allow for SSL
libraries that didn't support in-memory decryption.  It may not be necessary
anymore however.

Ryan

______________________________________________________________
Ryan Bloom				rbb@apache.org
Covalent Technologies			rbb@covalent.net
--------------------------------------------------------------

Mime
View raw message