httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Kraemer <Martin.Krae...@Fujitsu-Siemens.com>
Subject Re: [PATCH] 1.3: serialized accept for Cygwin OS
Date Mon, 24 Sep 2001 16:14:47 GMT
On Fri, Sep 21, 2001 at 03:35:15PM +0200, Stipe Tolj wrote:
>   * src/helpers/install.sh: Martin added the last time to much
> concerning the ".exe" extension detection while "make install", which
> in fact then did not work. This will work and has no impact on other
> OS.
>
> diff -ur apache-1.3/src/helpers/install.sh apache-1.3-cygwin/src/helpers/install.sh
> --- apache-1.3/src/helpers/install.sh	Tue Jun 12 10:24:53 2001
> +++ apache-1.3-cygwin/src/helpers/install.sh	Fri Sep 21 12:54:06 2001
> @@ -88,13 +88,10 @@
>  fi
>  
>  #  Check if we need to add an executable extension (such as ".exe") 
> -#  on specific OS to src and dst
> +#  on specific OS to src and dst.
> +#  At least Cygwin requires this to ensure a clean "make install".
>  if [ -f "$src.exe" ]; then
> -  if [ -f "$src" ]; then
> -    : # Cygwin [ test ] is too stupid to do [ -f "$src.exe" ] && [ ! -f "$src"
]
> -  else
>      ext=".exe"
> -  fi
>  fi
>  src="$src$ext"
>  dst="$dst$ext"

The idea was to make sure that .exe was assumed ONLY in the case that
no file _without_ .exe had been created. If both exist, then I don't
want to automatically assume that .exe is the default extension.

By removing the code above, you would do just that: favor .exe over 
"no extension" if both cases are found.

Originally, I coded that as  [ -f "$src.exe" ] && [ ! -f "$src" ] but
you told me that Cygwin's "test" is to dumb to grok this syntax.

Thus let's keep it the way it is. (Thanks, Jim!)

  Martin
-- 
<Martin.Kraemer@Fujitsu-Siemens.com>         |     Fujitsu Siemens
Fon: +49-89-636-46021, FAX: +49-89-636-47655 | 81730  Munich,  Germany

Mime
View raw message