httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <jerenkra...@ebuilt.com>
Subject Re: [PATCH] Take 2 of the http filter rewrite
Date Mon, 24 Sep 2001 20:35:08 GMT
On Mon, Sep 24, 2001 at 01:31:52PM -0700, Greg Stein wrote:
> > The brigades should not be returning more data than is asked for 
> > ever.
> 
> Fix the wording: not the brigades but the *filters*.
>
> And yes: I totally agree. I've said that a few times recently :-) I was just
> hoping that your patch could be done independently of the limiting thing.
> And that we could go fix the limited-return in a future step.

Yeah, you are right.  The brigades are fine - the core filter isn't
doing enough IMHO.

> > What happens then is that we now enter a condition where the 
> > caller may not be able to handle the data (i.e. I only wanted 10 
> > bytes you gave me 8192, oops).  This is fundamentally incorrect - 
> > changing scopes doesn't seem to be the answer.  -- justin
> 
> All right. If you're willing to tackle the limited return, then that would
> seem to be a good first step. The second step would be the patch you just
> posted.
> 
> IOW, could we get "limited return" first, then the reorg patch second? Or
> are the two things too comingled right now?

In theory, I think you could, but the limited return means shifting
stuff from http to core.  Then, the http filter needs to be rewritten
to handle the core doing the "right" thing now.  Since that is the
case, it seems logical to also remove dechunk by merging the two.

I've got my tree building with the new core filter.  I'll test it 
with httpd-test and flood.  If it looks good (I think it will!), 
I'll post and we can begin reviewing it.

If you think the posted patch is too much, I can see what I can 
do about splitting the two.  -- justin


Mime
View raw message