httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <jerenkra...@ebuilt.com>
Subject Re: [PATCH] Take 2 of the http filter rewrite
Date Mon, 24 Sep 2001 07:53:31 GMT
On Sun, Sep 23, 2001 at 09:35:31PM -0700, Ryan Bloom wrote:
> > The only real question is what happens when readbytes is -1 - a
> > higher-level filter explicitly asks for everything.  We'd then do a
> > blocking read for the entire socket until it is exhausted.  I think
> > the current code would have problems with it as well anyway.  I'm not
> > really sure what we can do here.  Thoughts?  -- justin
> 
> The current code doesn't have problems with this, because we rely on
> the fact that the HTTP_IN filter understands HTTP.  It knows when the request
> is done. Anything else is invalid.

Please take a look at the code again.  ap_http_filter when -1 is
passed in as readbytes will read until the socket is exhausted
and returns the entire brigade to the higher-level filter with EOS.
This is potentially eating up a pipelined request.

If this is an incorrect interpretation, I will be delighted to learn
how this works like you say it does.  =)  -- justin


Mime
View raw message