httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Stoddard" <b...@wstoddard.com>
Subject Re: cvs commit: httpd-2.0/server/mpm/worker worker.c
Date Wed, 19 Sep 2001 13:14:44 GMT

> On Wed, Sep 19, 2001 at 06:34:11AM -0000, jwoolley@apache.org wrote:
> > jwoolley    01/09/18 23:34:11
> > 
> >   Modified:    server/mpm/worker worker.c
> >   Log:
> >   I was kinda hoping those (void)some_function() and (request_rec *)NULL
> >   casts would go away before this committed, but alas I didn't say anything.
> >   :-)  This gets rid of them and a few others just like them that I also
> >   found in worker.c.
> 
> I don't know what the groupthink is on this, or if there is a precedent
> set, but I think the (void)s make it obvious to the reader that we
> are deliberately throwing away the return value.
> 
> As for the (request_rec *)NULL thing, either way is fine for me.
> 
> -aaron

It's obvious we are not using the return either way. Less is better so dump the cast :-)

Bill


Mime
View raw message