Return-Path: Delivered-To: apmail-new-httpd-archive@apache.org Received: (qmail 54675 invoked by uid 500); 6 Aug 2001 22:24:19 -0000 Mailing-List: contact new-httpd-help@apache.org; run by ezmlm Precedence: bulk Reply-To: new-httpd@apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list new-httpd@apache.org Received: (qmail 54664 invoked from network); 6 Aug 2001 22:24:19 -0000 Content-Type: text/plain; charset="iso-8859-1" From: Ryan Bloom Reply-To: rbb@covalent.net Organization: Covalent Technologies To: new-httpd@apache.org, Doug MacEachern Subject: Re: mod_cgid leaks on restarts Date: Mon, 6 Aug 2001 15:23:31 -0700 X-Mailer: KMail [version 1.2] References: In-Reply-To: MIME-Version: 1.0 Message-Id: <0108061523310L.11670@koj.rkbloom.net> Content-Transfer-Encoding: 8bit X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N Status: O X-Status: X-Keywords: X-UID: 157 +1 Ryan On Saturday 04 August 2001 15:01, Doug MacEachern wrote: > the pcgi pool appears to be the culprit. it is only used for the forked > child, moving the apr_pool_create(&pcgi, p) to happen in the child gets > rid of the leakage on restart. i don't understand why, it looks like pcgi > is properly destroyed in the parent. > > Index: modules/generators/mod_cgid.c > =================================================================== > RCS file: /home/cvs/httpd-2.0/modules/generators/mod_cgid.c,v > retrieving revision 1.88 > diff -u -r1.88 mod_cgid.c > --- modules/generators/mod_cgid.c 2001/07/30 16:18:05 1.88 > +++ modules/generators/mod_cgid.c 2001/08/04 21:45:29 > @@ -602,8 +602,6 @@ > } > > if (!first_time) { > - apr_pool_create(&pcgi, p); > - > total_modules = 0; > for (m = ap_preloaded_modules; *m != NULL; m++) > total_modules++; > @@ -614,6 +612,7 @@ > "Couldn't spawn cgid daemon process"); > } > else if (pid == 0) { > + apr_pool_create(&pcgi, p); > cgid_server(main_server); > exit(-1); > } -- _____________________________________________________________________________ Ryan Bloom rbb@apache.org Covalent Technologies rbb@covalent.net -----------------------------------------------------------------------------