httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brad Nicholes" <BNICHO...@novell.com>
Subject Re: cvs commit: apache-1.3/src/include httpd.h
Date Mon, 13 Aug 2001 17:49:04 GMT
   I guess you could say that it does but the reality is that this is a bug and should be fixed
in all platforms.  I just don't know how to do that on any other OS besides NetWare. :( The
issue comes down to the fact that if you enter the URL https://myserver.com/mydocs with no
trailing slash, Apache will redirect you to http://myserver.com:443/mydocs/ which causes a
problem on some if not all browsers.  This turns out to get even worse if your secure port
is not 443.  ap_http_method() looked like a good place to make the change since it appeared
that the orignators of this function had intended it to be implemented.  In fact the code
in ap_contruct_url() expects it to be implemented.

Brad

>>> Ryan Bloom <rbb@covalent.net> Monday, August 13, 2001 11:18:47 AM >>>

Doesn't this change how Apache works depending on which platform you
are on?

I dislike putting SSL into the server on just one platform for Apache 1.3.  IMO,
this should be done with a patch to the server when NetWare distributes it, not
with a modification to the core.

Of course, for 2.0, I thoroughly encourage putting this type of thing in.  I would
use different logic for 2.0, just because it can be done without #ifdef's.

Ryan

On Monday 13 August 2001 10:09, bnicholes@apache.org wrote:
> bnicholes    01/08/13 10:09:42
>
>   Modified:    src/include httpd.h
>   Log:
>   Redefined ap_http_method(r) to ap_os_http_method(r) for NetWare so that
>   we can appropriately recontruct the URL in ap_contruct_url() based on a
>   secure or unsecure socket.
>
>   Revision  Changes    Path
>   1.344     +4 -0      apache-1.3/src/include/httpd.h
>
>   Index: httpd.h
>   ===================================================================
>   RCS file: /home/cvs/apache-1.3/src/include/httpd.h,v
>   retrieving revision 1.343
>   retrieving revision 1.344
>   diff -u -r1.343 -r1.344
>   --- httpd.h	2001/05/15 16:30:57	1.343
>   +++ httpd.h	2001/08/13 17:09:42	1.344
>   @@ -141,7 +141,11 @@
>    #define DEFAULT_HTTP_PORT	80
>    #define DEFAULT_HTTPS_PORT	443
>    #define ap_is_default_port(port,r)	((port) == ap_default_port(r))
>   +#ifdef NETWARE
>   +#define ap_http_method(r) ap_os_http_method(r)
>   +#else
>    #define ap_http_method(r)	"http"
>   +#endif
>    #define ap_default_port(r)	DEFAULT_HTTP_PORT
>
>    /* --------- Default user name and group name running standalone
> ---------- */

-- 

______________________________________________________________
Ryan Bloom                        	rbb@apache.org 
Covalent Technologies			rbb@covalent.net 
--------------------------------------------------------------


Mime
View raw message