httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: [PATCH] mod_include fix
Date Fri, 17 Aug 2001 18:56:10 GMT
I played with the offset of the tag in the file so that I hit the
8192-byte boundary at a different spot in the tag and hit another
parse problem.

At this point, this patch on top of what I committed previously
handles both testcases :)

I'm gonna take a short break then write a perl CGI to put the tag at
specified offsets, run it for i = 0 to very-large-number, and if I
don't get any parsing errors I'll commit it.

Index: modules/filters/mod_include.c
===================================================================
RCS file: /home/cvspublic/httpd-2.0/modules/filters/mod_include.c,v
retrieving revision 1.122
diff -u -r1.122 mod_include.c
--- modules/filters/mod_include.c	2001/08/17 17:24:46	1.122
+++ modules/filters/mod_include.c	2001/08/17 18:48:28
@@ -270,8 +270,10 @@
         }
         while (c < buf + len) {
             if (ctx->bytes_parsed >= BYTE_COUNT_THRESHOLD) {
-                /* gonna start over parsing the directive next time through */
-                ctx->directive_length = 0;
+                if (ctx->state == PARSE_DIRECTIVE) {
+                    /* gonna start over parsing the directive next time through */
+                    ctx->directive_length = 0;
+                }
                 return dptr;
             }
 

-- 
Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...

Mime
View raw message