httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: [PATCH] fix segfaults related to ap_custom_response()
Date Fri, 17 Aug 2001 21:00:21 GMT
Will Lowe <harpo@thebackrow.net> writes:

> On Fri, Aug 17, 2001 at 01:59:34PM -0500, William A. Rowe, Jr. wrote:
> > We are unlikely to accept a patch that modifies request_rec structures,
> > since that (significantly) breaks binary compatiblity.
> 
> I was sorta afraid of that.  Even if it's at the *end* of the struct?
> I figured that wouldn't break much.
> 
> > I'd be happy to entertain a patch if you can avoid breaking binary
> 
> Hmm.  The problem is that ap_custom_response() seems to be meant to set
> custom responses on a per-request basis.  Is there anyplace else that I
> can store per-request data?

struct request_rec {
...
    /** Notes on *this* request */
    struct ap_conf_vector_t *request_config;
};

(I didn't look at the patch and have no opinion whether or not
request_config is appropriate, but it is a possibility.  See how it is
used in existing code.)

-- 
Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...

Mime
View raw message