httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: cvs commit: httpd-2.0/modules/http http_protocol.c
Date Wed, 01 Aug 2001 11:55:42 GMT
wrowe@apache.org writes:

> wrowe       01/07/31 21:08:36
> 
>   Modified:    modules/http http_protocol.c
>   Log:
>     Restore to 1.333 state (problematic, in that we could be facing >(size_t)
>     bytes, but better till I figure out the _right_ fix.
>   
>   Revision  Changes    Path
>   1.339     +1 -4      httpd-2.0/modules/http/http_protocol.c
>   
>   Index: http_protocol.c
>   ===================================================================
>   RCS file: /home/cvs/httpd-2.0/modules/http/http_protocol.c,v
>   retrieving revision 1.338
>   retrieving revision 1.339
>   diff -u -r1.338 -r1.339
>   --- http_protocol.c	2001/07/30 04:19:57	1.338
>   +++ http_protocol.c	2001/08/01 04:08:36	1.339
>   @@ -1435,11 +1435,8 @@
>    
>        do {
>            if (APR_BRIGADE_EMPTY(bb)) {
>   -            apr_size_t asmuch = bufsiz;
>   -            if (r->remaining < asmuch)
>   -                asmuch = (apr_size_t)r->remaining;
>                if (ap_get_brigade(r->input_filters, bb, AP_MODE_BLOCKING,
>   -                               &asmuch) != APR_SUCCESS) {
>   +                               &r->remaining) != APR_SUCCESS) {

I guess you know that r->remaining is apr_off_t but ap_get_brigade()
wants apr_size_t *?  (warnings now on AIX at least)

Is there a reason why r->remaining can't be apr_off_t?
-- 
Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...

Mime
View raw message