httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: cvs commit: httpd-2.0/modules/filters mod_include.c
Date Sat, 18 Aug 2001 13:40:40 GMT
"Brian Havard" <brianh@kheldar.apana.org.au> writes:

> On Sat, 18 Aug 2001 22:47:24 +1000 (EST), Brian Havard wrote:
> 
> Found it. In apr_buckets_file.c:file_read() line ~189 it makes a bucket
> manually but neglects to set the free function. This fixes the SEGV for me,
> but why am I the only one getting it?????

FWIW that looks reasonable to me (Cliff?  Ryan?), but for my testing
file_bucket->free isn't getting called (instead of your patch I stored
0xFEFEFEFE for the pointer).  I guess that is because the file bucket
keeps getting morphed into something else, and that bucket's free
routine is called?

> Index: apr_buckets_file.c
> ===================================================================
> RCS file: /home/cvs/apr-util/buckets/apr_buckets_file.c,v
> retrieving revision 1.53
> diff -u -r1.53 apr_buckets_file.c
> --- apr_buckets_file.c	2001/08/08 05:58:15	1.53
> +++ apr_buckets_file.c	2001/08/18 13:11:09
> @@ -191,6 +191,7 @@
>          b->length = filelength;
>          b->data   = a;
>          b->type   = &apr_bucket_type_file;
> +        b->free   = free;
>          APR_BUCKET_INSERT_AFTER(e, b);
>      }
>      else {

-- 
Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...

Mime
View raw message