httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: [PATCH] for mod_mime seg fault in 2.0.23 :-)
Date Wed, 15 Aug 2001 02:50:30 GMT
Greg Ames <gregames@remulak.net> writes:

> This fixes the seg fault on my Linux box:
> 
> Index: modules/http/mod_mime.c
> ===================================================================
> RCS file: /home/cvs/httpd-2.0/modules/http/mod_mime.c,v
> retrieving revision 1.50
> diff -u -d -b -r1.50 mod_mime.c
> --- modules/http/mod_mime.c     2001/08/14 02:35:55     1.50
> +++ modules/http/mod_mime.c     2001/08/14 19:39:45
> @@ -220,13 +220,10 @@
>      attrib_info *suffix;
>  
>      if (base->extension_mappings && add->extension_mappings) {
> -        if (base->copy_mappings)
> -            new->extension_mappings = base->extension_mappings;
> -        else {
>              new->extension_mappings = apr_hash_make(p);
>              overlay_extension_mappings(p, base->extension_mappings,
>                                         new->extension_mappings);
> -        }
> +
>          overlay_extension_mappings(p, add->extension_mappings,
>                                     new->extension_mappings); 

I suggest committing it.  Sure, Bill**2 are suggesting more extensive
changes but this works in the meantime.  Even if "in the meantime"
isn't very long, we know that what was in CVS before the
more-extensive changes was working; also, reviewing the more extensive
changes will be a comparison of working with working instead of
working with broken, for what that is worth.

-- 
Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...

Mime
View raw message