httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: cvs commit: httpd-2.0/modules/filters mod_include.c
Date Thu, 02 Aug 2001 16:58:47 GMT
rbb@apache.org writes:

>   Index: mod_include.c
>   ===================================================================
>   RCS file: /home/cvs/httpd-2.0/modules/filters/mod_include.c,v
>   retrieving revision 1.118
>   retrieving revision 1.119
>   diff -u -r1.118 -r1.119
>   --- mod_include.c	2001/08/02 05:27:06	1.118
>   +++ mod_include.c	2001/08/02 16:35:22	1.119
>   @@ -2466,7 +2466,7 @@
>                                 (tmp_dptr != APR_BRIGADE_SENTINEL(*bb)));
>                    }
>    
>   -                return;
>   +                return APR_SUCCESS;

I was looking into these warnings a bit earlier today.  Isn't this an
error path?  Shouldn't we be returning the apr_status_t returned from
get_combined_directive()?

-- 
Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...

Mime
View raw message