httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cody Sherr <csh...@covalent.net>
Subject Re: [PATCH] <limit> directive extended to arbitrary methods
Date Wed, 01 Aug 2001 21:04:58 GMT

I was concerned instead with the signed 2's complement representation of
-1, which is all bits high, which is assigned to bitmasks in a few places
in the code as an error condition, so I went conservative and decided to
not use the last bit, to not confuse all methods set with an error
condition.


On Wed, 1 Aug 2001, William A. Rowe, Jr. wrote:

> Mr. Trawick can answer this one :)
>
> From: "Cody Sherr" <csherr@covalent.net>
> Sent: Wednesday, August 01, 2001 11:40 AM
>
> > +/* The max method number. Method numbers are used to shift bitmasks,
> > + * so this cannot exceed 63, and all bits high is equal to -1, which is a
> > + * special flag, so the last bit used has index 62.
>
> You are assuming something here about the cpu that you might not get away with
> on all platforms.  I'd steal a bit instead of the -1 flag, so you can be sure
> it works across architectures.  Do we still have CPUs out there in Apache-land
> with sign-bit-negation instead of bitwise-negation?
>
>

-- 
Cody Sherr

Engineer
Covalent Technologies

phone: (415)536-5292
email: csherr@covalent.net



Mime
View raw message