httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Doug MacEachern <do...@covalent.net>
Subject Re: cvs commit: httpd-2.0/modules/ssl README mod_ssl.h ssl_engine_init.c ssl_util.c
Date Fri, 24 Aug 2001 05:42:16 GMT
On Thu, 23 Aug 2001, Justin Erenkrantz wrote:
 
> I meant to review this patch, but I accidentally hit the delete key on 
> the original message.  Anyway, that APR_LOCKALL can be APR_INTRAPROCESS.
> We're only concerned about safety within our process not across 
> multiple processes - there is no need to needlessly lock across
> processes here.

right, thanks, that change is in.
 
> IMHO, the call to ssl_util_thread_setup should be moved to 
> ssl_init_Child and even potentially surrounded by 
> #if APR_HAS_THREADS.  -- justin

why child init rather than module init?
i did turn off the locking unless the mpm is threaded.  isn't it possible
that APR_HAS_THREADS is true even though the mpm is not threaded?



Mime
View raw message