httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ian Holsman <i...@cnet.com>
Subject Re: 2.0.24 ready for beta?
Date Thu, 23 Aug 2001 17:11:34 GMT
On Thu, 2001-08-23 at 09:33, Bill Stoddard wrote:
> What is the failure? And why was this not broken in Apache 1.3? The change seems
> reasonable but curious if there is a better way to fix this.
the failure happens in ap_escape_html as it always assumes a not-null
value being passed in. 


to reproduce you need to have the main file R-Proxied and have it do
something like <!--#include virtual="/crash/penv.html"-->
and have "/crash/penv.html" have a <!--#printenv-->

I didn't put a patch through on ap_escape_html as if it checked for
null, we would probably not catch problems like this one.



> 
> Bill
> 
> > On Thu, 2001-08-23 at 08:09, Bill Stoddard wrote:
> > > With the last mod_include fix, can we bump the tag on mod_include and go beta?
> > >
> > I had 1 patch to mod_include I'd like to see included.
> > It deals with the case where the main page is not a file.
> >
> >
> > Index: mod_include.c
> > ===================================================================
> > RCS file: /home/cvspublic/httpd-2.0/modules/filters/mod_include.c,v
> > retrieving revision 1.125
> > diff -u -u -r1.125 mod_include.c
> > --- mod_include.c 2001/08/18 17:36:26 1.125
> > +++ mod_include.c 2001/08/23 15:45:43
> > @@ -113,7 +113,10 @@
> >      apr_table_setn(e, "LAST_MODIFIED",
> >                ap_ht_time(r->pool, r->finfo.mtime, timefmt, 0));
> >      apr_table_setn(e, "DOCUMENT_URI", r->uri);
> > -    apr_table_setn(e, "DOCUMENT_PATH_INFO", r->path_info);
> > +    /* path info is not set if the pages has come from mod-proxy */
> > +    if (r->path_info && *r->path_info ) {
> > +        apr_table_setn(e, "DOCUMENT_PATH_INFO", r->path_info);
> > +    }
> >      if (apr_get_username(&pwname, r->finfo.user, r->pool) ==
> > APR_SUCCESS) {
> >          apr_table_setn(e, "USER_NAME", pwname);
> >      }
> >
> >
> > > Bill
> > --
> > Ian Holsman          IanH@cnet.com
> > Performance Measurement & Analysis
> > CNET Networks   -   (415) 364-8608
> >
-- 
Ian Holsman          IanH@cnet.com
Performance Measurement & Analysis
CNET Networks   -   (415) 364-8608


Mime
View raw message