httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Pane <bp...@pacbell.net>
Subject Re: [PATCH] mod_mime pool testing against cvs head
Date Thu, 16 Aug 2001 23:05:18 GMT
William A. Rowe, Jr. wrote:

>>Now, this is a far as I can take it.  Segfaults (from the hash _and_ the elements)
>>should be gone.  I don't have the time or energy to focus on the optimization patch

>>to reflect this last update, especially as exactly one (1) individual has commented
>>on the 'optimization guideslines' draft I posted.
>>
>
>Ok... last chance.  Here's the optimized patch against the current tree.
>
>Anyone who suggests this adds wicked complexity is fooling themselves, it's no more
>nasty than actually assuring that your hash table or elements aren't being corrupted.
>
The patch looks good to me.  In the common case that ought to be fast
(no .htaccess files, and no remove lists), this new logic doesn't have
to dup the hash tables or their contents, so I'm comfortable with it
from a performance perspective.

--Brian




Mime
View raw message