httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <>
Subject Re: [PATCH] mod_mime performance tweaks, revised
Date Tue, 07 Aug 2001 03:31:14 GMT
From: "Brian Pane" <>
Sent: Monday, August 06, 2001 10:13 PM

> William A. Rowe, Jr. wrote:
> >From: "Brian Pane" <>
> >Sent: Monday, August 06, 2001 4:51 PM
> >
> >
> >>The patch in question got committed a long time ago, back in version
> >>1.43 of mod_mime.c.  I checked the current rev in CVS, and it's still
> >>using the hash tables that my patch introduced.
> >>
> >
> >Ahhh.  I thought you offered a further patch to allow just segments of the filename
> >to be matched, so that index.en would match index.html.en.  I must have been imagining
> >things :)
> I bet you're thinking of the patch I posted to optimize away the
> ap_getword calls in mod_mime (which wasn't committed).  That
> one definitely won't work with the latest mod_mime code.  I'll
> see if I can do the same optimization (replace ap_getword with
> inline string-scanning to eliminate some string-copying) against
> the current code base; if it works, I'll post a patch.

Actually, once updated, it will work better.  It can solve the tangle of index.html.unk.en
not being served when the user requests index.html.unk because it can recognize that the
user asked for both index and unk.  Right now, it strcmp's index.unk (the unknown bits)
to index.html.unk, and will die.

If it makes the original patch simpler/lighter, I do insist we will only parse elements
forward, so a request for index.html.en can't return index.en.html (two very different
names.)  If we can agree on that, your patch should be very fast :)


View raw message