httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: [PATCH] mod_mime performance tweaks, revised
Date Mon, 06 Aug 2001 20:43:50 GMT
From: "Brian Pane" <bpane@pacbell.net>
Sent: Wednesday, June 27, 2001 11:50 AM


> I've revised my mod_mime optimization patch a bit
> to try to speed up the merge-per-dir-config implementation.
> This patch replaces the previous one that I posted.  (That's the
> last of my changes, I promise, until somebody reviews this
> one :-)

Brian,

  As you can guess, the recent mime and negotation fixes entirely broke this patch :(

  I won't have much time until next Tuesday, but I'd be happy to review and then
commit the idea, based on a couple of significant restrictions;

1. the order of suffixes _must_ remain constant.
   That is, if the user asks for something.html.en, they cannot be served 
   something.en.html.  If they ask for simply something, something.html, or
   something.en, I'd be happy if we serve something.html.en or something.en.html
   based on negotation (if they both existed, the smaller would win.)

2. the negotation exception-list code needs to be changed to check the exceptions
   list one segment at a time against the segments the user requested, also in the 
   same sequence.  So asking for index.bak might return index.html.en.bak, or even
   index.bak.html.en, but asking for index.html can _never_ find index.bak since
   the .bak extension isn't recognized by mod_mime.

  So if you will fix the patch against these requirements, I'm +1, and will review
and commit if nobody objects, sometime early next week (cc wrowe at rowe-clan.net so
it ends up on my priority stack, I'll be catching up on a ton of email Monday.)

Bill



Mime
View raw message