httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: cvs commit: httpd-2.0/modules/http mod_mime.c
Date Sat, 04 Aug 2001 23:25:14 GMT
Evidently, VC.  Although I will say I was very tired, and had in mind (contemplating
the issues for about six hours away from the PC) exactly the further restrictions we 
required.  It's possible that this code never compiled, I missed it, but my prelim tests 
just happened to indicate success.

Regardless, thank you for the fix, Jeff!

Anyone who cares to vet this code, please comment if you've reviewed how it affects
Multiviews negotation and if you believe the new behavior is more correct, stable
and predictable, or if you see any new (potential) problems.

Bill

----- Original Message ----- 
From: "Jeff Trawick" <trawick@attglobal.net>
To: <new-httpd@apache.org>
Cc: <httpd-2.0-cvs@apache.org>
Sent: Saturday, August 04, 2001 6:24 AM
Subject: Re: cvs commit: httpd-2.0/modules/http mod_mime.c


> wrowe@apache.org writes:
> 
> >   Index: mod_negotiation.c
> >   ===================================================================
> >   RCS file: /home/cvs/httpd-2.0/modules/mappers/mod_negotiation.c,v
> >   retrieving revision 1.63
> >   retrieving revision 1.64
> >   diff -u -r1.63 -r1.64
> >   --- mod_negotiation.c 2001/08/03 22:57:47 1.63
> >   +++ mod_negotiation.c 2001/08/04 04:32:58 1.64
> 
> >   +        char *base = apr_array_pstrcat(sub_req->pool, exception_list, '.');
> 
> Which lousy compiler would actually compile this statement?  It isn't
> a valid context for a variable declaration.
> 
> -- 
> Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
>        http://www.geocities.com/SiliconValley/Park/9289/
>              Born in Roswell... married an alien...
> 


Mime
View raw message