httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: httpd-2.0/modules/ssl mod_ssl.c mod_ssl.h ssl_engine_ext.c ssl_engine_vars.c ssl_expr_parse.c ssl_expr_parse.h ssl_expr_scan.c ssl_scache.c
Date Thu, 23 Aug 2001 03:43:16 GMT
On Wed, Aug 22, 2001 at 10:58:08PM -0000, wrowe@apache.org wrote:
> wrowe       01/08/22 15:58:08
> 
>   Modified:    modules/ssl mod_ssl.c mod_ssl.h ssl_engine_ext.c
>                         ssl_engine_vars.c ssl_expr_parse.c ssl_expr_parse.h
>                         ssl_expr_scan.c ssl_scache.c
>   Log:
>     Remove a ton o' cruft.  Moves the mod_log_config 'var' extensions to
>     ssl_engine_vars.c.
>...
>   --- ssl_expr_parse.c	2001/05/05 13:21:53	1.3
>   +++ ssl_expr_parse.c	2001/08/22 22:58:07	1.4
>...
>   +
>   +/*  A Bison parser, made from ssl_expr_parse.y
>   +    by GNU Bison version 1.28  */

Why do we have Bison output in our tree? Per our standard guidelines, all
generated files should stay out of the tree...

>...
>   --- ssl_expr_scan.c	2001/08/22 15:40:28	1.4
>   +++ ssl_expr_scan.c	2001/08/22 22:58:07	1.5
>   @@ -18,6 +18,7 @@
>    /* A lexical scanner generated by flex */
>    
>    /* Scanner skeleton version:
>   + * $Header: /home/cvs/httpd-2.0/modules/ssl/ssl_expr_scan.c,v 1.5 2001/08/22 22:58:07
wrowe Exp $
>     */

Same here. And we probably don't want that $Header$ in there, either.


I would think the Bison/flex output would be generated during buildconf
(rather than a Makefile) so that we don't have to expect users to generate
them at build time (meaning they would have to have Bison/flex).

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message