httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Kraemer <Martin.Krae...@Fujitsu-Siemens.com>
Subject Re: [PATCH] AcceptMutex and SingleListen runtime
Date Tue, 21 Aug 2001 14:56:46 GMT
On Mon, Aug 20, 2001 at 02:36:25PM -0400, Jim Jagielski wrote:
> Below is the patch to implement AcceptMutex and SingleListen as
> runtime parameters. There is still a little lint to work through, but
> this is the implementation (eg: it would be nice to print/log the
> settings).

Great!!!! Yet untested, but that's something I always wanted.
One thing: in the test/ directory, we have the time-sem.c
tool which also has
 -DUSE_SYSVSEM_SERIALIZED_ACCEPT -DNO_SEM_UNDO
The NO_SEM_UNDO is a very important parameter on SVR4, without it
you will quickly hit a system-defined (tuneable but usually low,
around 60) limit of maximum undo structures in the kernel.

When apache hits that limit, it simply exits. No recovery, no restart,
simply exit. I had customers complain bitterly.....

I don't know whether Dean Gaudet is still lurking, maybe he knows
whether there are reasons which forbid the use of the
-DNO_SEM_UNDO alternative in apache itself. I was under the
impression that nobody implemented it yet, but it would be useful.

Could it be added to the patch?

> +		accept_mutex_init_fptr = 	&accept_mutex_init_flock;

In ansi C you don't need the '&' to make a function pointer.

Thanks!

   Martin
-- 
<Martin.Kraemer@Fujitsu-Siemens.com>    |       Fujitsu Siemens
       <martin@apache.org>              |   81730  Munich,  Germany

Mime
View raw message