httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: [PATCH] Apache 1.3.21-dev for NetWare builds (5)
Date Mon, 27 Aug 2001 15:17:53 GMT
From: "Pavel Novy" <novy@feld.cvut.cz>
Sent: Monday, August 27, 2001 9:08 AM


> I suggest to fix the problem as described (patch attached), even if it will be considered
as CodeWarrior's bug (and fixed, then)
by Metrowerks or not. I've detailedly analyzed the issue and I see no way how to stay backwardly
compatible with this issue, so all
binaries for NetWare platform (Apache core+modules from CVS sources and all "3rd party" external
modules produced with CW) should be
re-built after the fix (if it will be commited) - it will not be possible to mix new NLMs
with older Apache core or modules.
>
> I have tested the fix with CW 5.3 and gcc 2.95.3 and it seems that alignment of problematic
structures is the same (it differs
from current status quo, of course). The change in the source file shared on all platforms
is requested, so verification on these
ones will be needed. I don't expect problems (no change in alignment) on platforms where the
GNU stuff is used (gcc). Thanks.

Pavel,

  I'm sorry, I cannot see this code change for the 1.3 generation.  I sympathize that the
implementors on the Netware platform refuse to see eye to eye (or even attempt to bring
some sort of compatiblity options to the table.)  And the unsigned char solution is very
slow, compared to integer manipulation, so I'm not sure we would choose that anyways.

  Please bring this discussion to Apache 2.0.  I know Brad Nicholes and company at Novell
are working hard to support Apache 2.0.  This implementation will be a far more secure and
stable platform than the 1.3 hybrid/threaded implementations (win32/os2/netware etc.)

  If we direct our energies at solving the problem there, and we can agree on a mechansim,
I see this issue being resolved in Apache 2.0.

Bill





--------------------------------------------------------------------------------


> --- util_uri.h.orig Mon Feb 26 16:49:32 2001
> +++ util_uri.h Mon Aug 27 15:44:41 2001
> @@ -106,10 +106,10 @@
>
>      unsigned short port; /* The port number, numeric, valid only if port_str != NULL
*/
>
> -    unsigned is_initialized:1;
> +    unsigned char is_initialized:1;
>
> -    unsigned dns_looked_up:1;
> -    unsigned dns_resolved:1;
> +    unsigned char dns_looked_up:1;
> +    unsigned char dns_resolved:1;
>
>  } uri_components;
>
>


Mime
View raw message