httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ryan Bloom <...@covalent.net>
Subject Re: cvs commit: httpd-2.0/modules/http http_protocol.c
Date Mon, 27 Aug 2001 00:19:08 GMT
On Sunday 26 August 2001 17:20, Greg Stein wrote:
> On Sun, Aug 26, 2001 at 03:18:41PM -0700, Ryan Bloom wrote:
> > On Sunday 26 August 2001 12:54, Doug MacEachern wrote:
> > > On Sun, 26 Aug 2001, Marc Slemko wrote:
> > > > hang on, is this about keepalives or chunked encoding?
> > >
> > > both.
> > >
> > > the check always fails because ap_content_length_filter has set content
> > > length before ap_set_keepalive is called.  the right fix would probably
> > > be to check http/1.1-oneness eariler and remove (or not add) the
> > > ap_content_length_filter if r->chunked.
> >
> > Can't do that.  The content-length filter always computes the full
> > content length, even if it isn't put in the response.  That way, we can
> > log it correctly.
>
> I'd prefer to log it as "0" or somesuch, rather than buffer the response
> just for the sake of logging.
>
> Not of a particular mind here, but it *does* seem expensive to buffer just
> for logging's sake.

I wasn't clear.  We don't buffer, we just keep on counting.

Ryan

______________________________________________________________
Ryan Bloom                        	rbb@apache.org
Covalent Technologies			rbb@covalent.net
--------------------------------------------------------------

Mime
View raw message