httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ryan Bloom <...@covalent.net>
Subject Re: cvs commit: httpd-2.0/server/mpm/worker worker.c
Date Sun, 26 Aug 2001 01:42:39 GMT
On Saturday 25 August 2001 18:40, dougm@apache.org wrote:
> On Sat, 25 Aug 2001, Ryan Bloom wrote:
> > This will break things.  We will no longer be keeping track of the
> > listener, which is a bad thing.  I will fix this later this weekend, but
> > the worker MPM is broken now.
>
> its working for me.  was broken before, with this config:
>
> <IfModule worker.c>
>     StartServers         1
>     MaxClients           1
>     MinSpareThreads      1
>     MaxSpareThreads      1
>     ThreadsPerChild      1
>     MaxRequestsPerChild  0
> </IfModule>
>
> httpd cannot serve any requests.
> i don't know the code at all but ap_threads_per_child is compared to
> threads_created, which is only incremented for request threads.
> threads_created is not incremented when the listener threads is created.
> so i don't see how the listener thread was ever "kept track of".

I agree that it was broken before, but the shutdown and restart most likely
won't work anymore.  Someplace, we have to have the status of the listener
thread.  Before this patch, the parent process could always tell what the 
child was doing by looking at scoreboard[0].  We can't do that anymore.

I should have documented that, but I didn't.  This MPM is much better than it
used to be, but it still needs some work.  I am not suggesting backing out
this change, just wanted to make people aware that there is still work
needed on this MPM.

Ryan

______________________________________________________________
Ryan Bloom                        	rbb@apache.org
Covalent Technologies			rbb@covalent.net
--------------------------------------------------------------

Mime
View raw message