httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ryan Bloom <...@covalent.net>
Subject Re: cvs commit: httpd-2.0/server/mpm/worker worker.c
Date Sun, 26 Aug 2001 01:29:49 GMT

This will break things.  We will no longer be keeping track of the listener, which
is a bad thing.  I will fix this later this weekend, but the worker MPM is broken
now.

Ryan

On Saturday 25 August 2001 18:17, dougm@apache.org wrote:
> dougm       01/08/25 18:17:32
>
>   Modified:    server/mpm/worker worker.c
>   Log:
>   i think the answer to aaron's question is "a typo".  otherwise there is
>   actually 1 less thread available to serve requests than configured.
>
>   Revision  Changes    Path
>   1.16      +2 -3      httpd-2.0/server/mpm/worker/worker.c
>
>   Index: worker.c
>   ===================================================================
>   RCS file: /home/cvs/httpd-2.0/server/mpm/worker/worker.c,v
>   retrieving revision 1.15
>   retrieving revision 1.16
>   diff -u -r1.15 -r1.16
>   --- worker.c	2001/08/24 16:49:39	1.15
>   +++ worker.c	2001/08/26 01:17:32	1.16
>   @@ -755,9 +755,8 @@
>        my_info->sd = 0;
>        apr_thread_create(&listener, thread_attr, listener_thread, my_info,
> pchild); while (1) {
>   -        /* Does ap_threads_per_child include the listener thread?
>   -         * Why does this forloop start at 1? -aaron */
>   -        for (i = 1; i < ap_threads_per_child; i++) {
>   +        /* Does ap_threads_per_child include the listener thread? */
>   +        for (i = 0; i < ap_threads_per_child; i++) {
>                int status =
> ap_scoreboard_image->servers[child_num_arg][i].status;
>
>                if (status != SERVER_GRACEFUL && status != SERVER_DEAD) {

-- 

______________________________________________________________
Ryan Bloom                        	rbb@apache.org
Covalent Technologies			rbb@covalent.net
--------------------------------------------------------------

Mime
View raw message