httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ryan Bloom <...@covalent.net>
Subject Re: cvs commit: httpd-2.0/modules/mappers mod_negotiation.c
Date Thu, 23 Aug 2001 21:05:38 GMT
On Thursday 23 August 2001 13:53, William A. Rowe, Jr. wrote:
> From: <trawick@apache.org>
> Sent: Thursday, August 23, 2001 3:29 PM
>
> > trawick     01/08/23 13:29:47
> >
> >   Modified:    modules/mappers mod_negotiation.c
> >   Log:
> >   please no // in Apache code... it doesn't compile everywhere
> >
> >   a note about why it is commented out would be appropriate too
> >
> >   Revision  Changes    Path
> >   1.73      +4 -3      httpd-2.0/modules/mappers/mod_negotiation.c
> >
> >   Index: mod_negotiation.c
> >   ===================================================================
> >   +        /*if (r->method_number == M_OPTIONS) {
> >   +         *    return ap_send_http_options(r);
> >   +         *}
> >   +         */
> >            if (r->method_number != M_GET && r->method_number != M_POST)
{
> >                return HTTP_METHOD_NOT_ALLOWED;
> >            }
>
> Because I'm less than clear on the subject, so I will ask (now that you've
> reminded me)...
>
> who's job is it to answer an M_OPTIONS request?  Every module's?  Then the
> mod_cgi family is broken (this is what led me to discover that viewcvs.cgi
> hangs on HEAD, maybe other cgi's are hanging, as well.)
>
> If it's the handler's, we should review all the modules for this
> requirement. If it's supposed to be the server, this code can disappear.

Both should be able to handle it.  Basically, the default handler should do it
if nobody else does.  But, modules should be allowed to handle M_OPTIONS
requests.

Ryan

______________________________________________________________
Ryan Bloom                        	rbb@apache.org
Covalent Technologies			rbb@covalent.net
--------------------------------------------------------------

Mime
View raw message