httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ryan Bloom <...@covalent.net>
Subject Re: [PATCH] repost: <limit> directive extended to arbitrary methods
Date Thu, 02 Aug 2001 04:14:02 GMT

> I caught that... the other bit that I hinted at in my last message was
> pretty simple...
>
> when we first query, if the table doesn't exist, stuff elements n ..
> FIXED_METHODS

Get this done after the initial commit is in.  Since we don't currently stuff any
of the core methods in, we don't want to add them in the first commit.

>
> +++ include/httpd.h 2001/08/02 01:41:18
> @@ -478,8 +478,6 @@
>  /* Methods recognized (but not necessarily handled) by the server.
>   * These constants are used in bit shifting masks of size int, so it is
>   * unsafe to have more methods than bits in an int.  HEAD == M_GET.
> - * This list must be tracked by the list in http_protocol.c in routine
> - * ap_method_name_of().
>
>
> Don't you dare eliminate that comment!!!

Don't worry, I put it back.

> @@ -498,7 +496,10 @@
>  #define M_UNLOCK    14
>  #define M_INVALID   15
>
> -#define METHODS     16
> +/* METHODS needs to be equal to the number of bits
> + * we are using for limit masks.
> + */
> +#define METHODS     64
>
>
> Add one more placeholder, FIXED_METHODS, corresponding to the last
> M_INVALID + 1.

It's already there.  Look for METHOD_NUMBER_FIRST in http_protocol.h.  :-)

> Stuff them in the hash and pull out all the bogus tests from
> ap_method_number_of!!! You can't add a new 'GOOBLE' method, it will map to
> 'G' -- 'GET'.

I dislike changing how the core works in the same patch as when we introduce a
new API.  Let's commit the API change, and then fix the core.  And GOOBLE won't
map to GET, because we strcmp the two values.

Ryan

_____________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
Covalent Technologies			rbb@covalent.net
-----------------------------------------------------------------------------

Mime
View raw message