httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <>
Subject Re: [PATCH] Mkae Apache Monitor Display Windows XP correctly
Date Wed, 08 Aug 2001 21:09:47 GMT

  with only 3 recognized apache services (more on that in a minute) ... it consumes
a working set of 1.8 MB (!!!) we need to rip out a bit of this cruft.  K.I.S.S!

  The about box is a waste (in most programs), but _especially_ in a task bar 
application reporting the Windows OS (and all the dead-weight to go along with it.)
A "What's This?" tooltip box is more than sufficient, no?  Only my touchpad has a real
"About..." box, and it wastes no effort on reporting the Windows version :)

  If they don't know which windows they are using, oh well.

  I'll offer a patch Monday if nobody beats me to it.  (I'm following these 
discussions off-line).  I will also hook in apr.lib (static, not dynamic) for
nothing more than table and pool create/destruct...

  Pools should make this app very memory-lite, since each iteratation can gain a
sub pool that is then destroyed cleanly (without the leaking resources).
Using a table or hash to track the installed/running services (when there are 
many) will also be a nice improvement.

  TARGET:  500kb working set, or less!  Possible?  Don't know yet.


[I've renamed each generation of Apache.exe by number, since all 7 versions I track are
running on different ports.  Apache1.3.14.exe means more when I look at the process list
than seeing 30 Apache's.  Of course, that breaks the association for the task bar app,
as well.  I'll try working up some cute fix for this quandry next week, because I'd sure
like to fold all 10 of my servers under this controller :)]

----- Original Message ----- 
From: "Jerry Baker" <>
To: <>
Sent: Tuesday, August 07, 2001 8:01 PM
Subject: [PATCH] Mkae Apache Monitor Display Windows XP correctly

> Index: ApacheMonitor.c
> ===================================================================
> RCS file: /home/cvspublic/httpd-2.0/support/win32/ApacheMonitor.c,v
> retrieving revision 1.2
> diff -u -r1.2 ApacheMonitor.c
> --- ApacheMonitor.c     2001/08/07 19:54:10     1.2
> +++ ApacheMonitor.c     2001/08/08 00:58:33
> @@ -212,7 +212,7 @@
>              else if (osvi.dwMajorVersion == 5 && osvi.dwMinorVersion ==
> 0)
>                  strcpy(szVersion, "MS Windows 2000 ");
>              else if (osvi.dwMajorVersion == 5 && osvi.dwMinorVersion ==
> 1)
> -                strcpy(szVersion, "Whistler ");
> +                strcpy(szVersion, "MS Windows XP ");
>              /* Test for product type.*/
>              if (bOsVersionInfoEx)

View raw message