Return-Path: Delivered-To: apmail-new-httpd-archive@apache.org Received: (qmail 49245 invoked by uid 500); 30 Jul 2001 03:55:07 -0000 Mailing-List: contact new-httpd-help@apache.org; run by ezmlm Precedence: bulk Reply-To: new-httpd@apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list new-httpd@apache.org Received: (qmail 49234 invoked from network); 30 Jul 2001 03:55:07 -0000 Date: Sun, 29 Jul 2001 20:52:20 -0700 From: Brian Pane Subject: Re: [PATCH] remove some more strdup calls To: new-httpd@apache.org Message-id: <3B64D9F4.4040302@pacbell.net> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii; format=flowed Content-transfer-encoding: 7BIT X-Accept-Language: en-us User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.2) Gecko/20010628 References: X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N Marc Slemko wrote: >On Sun, 29 Jul 2001, Brian Pane wrote: > >>Here's another small performance patch to remove calls >>to apr_pstrdup, this time in location_walk. >> > >erm... doesn't this change mean that we are mucking with r->uri directly >by calling ap_no2slash() on it? Isn't that a problem and the whole point >behind the strdup? r->uri should remain the original one, not the one >with whatever fixups we use for whatever reason... > Please forgive me if I'm just missing something obvious, but why would leaving redundant slashes in r->uri be considered a good thing? It seems like this only makes life more complicated for downstream code, because any module that does transformations based on URI must be prepared to deal with redundant slashes too. --Brian