Return-Path: Delivered-To: apmail-new-httpd-archive@apache.org Received: (qmail 41693 invoked by uid 500); 1 Jul 2001 22:58:28 -0000 Mailing-List: contact new-httpd-help@apache.org; run by ezmlm Precedence: bulk Reply-To: new-httpd@apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list new-httpd@apache.org Received: (qmail 41643 invoked from network); 1 Jul 2001 22:58:25 -0000 Date: Sun, 1 Jul 2001 15:58:04 -0700 From: Justin Erenkrantz To: new-httpd@apache.org Subject: Re: cvs commit: httpd-2.0/server/mpm/threaded threaded.c Message-ID: <20010701155804.E7717@ebuilt.com> References: <20010701224934.34100.qmail@apache.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from rbb@covalent.net on Sun, Jul 01, 2001 at 03:51:43PM -0700 X-AntiVirus: scanned for viruses by AMaViS 0.2.1-pre3 (http://amavis.org/) X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N On Sun, Jul 01, 2001 at 03:51:43PM -0700, rbb@covalent.net wrote: > On 1 Jul 2001 rbb@apache.org wrote: > > > rbb 01/07/01 15:49:33 > > > > Modified: server/mpm/threaded threaded.c > > Log: > > Fix the threaded MPM perform_idle_server_maintenance. Basically, we now > > count how many threads are actually idle, regardless of which process they > > are in. This patch makes us use (min_spare_threads|max_spare_threads) > > * number_of_running_servers to determine if we should kill of processes or > > start new ones. This MPM no longer thrashes killing child processes as > > soon as they are created, and the server continues to serve requests even > > if the server is gracefully restarted and each child has one active thread. > > This patch should fix the threaded MPM. If people will test it over the > next few hours, I will roll 2.0.20 late tonight. I plan to wait about 3-4 > hours before I roll, so that people can comment on if this solved their > problem or not. Can't we just retag that one file (threaded.c) as APACHE_2_0_19 (whatever) and reroll? Nobody but the "few" of us on here know about 2.0.19, right? -- justin