Return-Path: Delivered-To: apmail-new-httpd-archive@apache.org Received: (qmail 99719 invoked by uid 500); 31 Jul 2001 17:10:48 -0000 Mailing-List: contact new-httpd-help@apache.org; run by ezmlm Precedence: bulk Reply-To: new-httpd@apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list new-httpd@apache.org Received: (qmail 99689 invoked from network); 31 Jul 2001 17:10:47 -0000 Errors-To: Message-ID: <09e501c119e3$5fa78810$93c0b0d0@roweclan.net> From: "William A. Rowe, Jr." To: References: <877AC5B5F768D511A51600A0C9F4841801DE33D4@xcup01.cup.hp.com> Subject: Re: cvs commit: httpd-2.0/modules/ssl ssl_engine_io.c Date: Tue, 31 Jul 2001 12:07:07 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.50.4133.2400 X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4133.2400 X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N Not if BIO_write is defined in terms of an int. ----- Original Message ----- From: "GAWLAS,JULIUS (HP-Cupertino,ex1)" To: Sent: Tuesday, July 31, 2001 11:52 AM Subject: RE: cvs commit: httpd-2.0/modules/ssl ssl_engine_io.c > Bill, > > no to pick in details but in your latest fix > > > Index: ssl_engine_io.c > > =================================================================== > > RCS file: /home/cvs/httpd-2.0/modules/ssl/ssl_engine_io.c,v > > retrieving revision 1.10 > > retrieving revision 1.11 > > diff -u -r1.10 -r1.11 > > --- ssl_engine_io.c 2001/07/31 03:04:55 1.10 > > +++ ssl_engine_io.c 2001/07/31 16:41:13 1.11 > > @@ -280,10 +280,9 @@ > > return APR_SUCCESS; > > } > > > > - assert(len > 0); > > - > > - n = BIO_write (pRec->pbioRead, data, len); > > - assert(n == len); > > + n = BIO_write (pRec->pbioRead, data, len); > > + > > + assert(n >= 0 && (apr_size_t)n == len); > > > > ssl_hook_process_connection (pRec); > > wouldn't it be easier and bit cleaner to simply declare n as apr_size_t? > > apr_size_t n; > > Julius >