httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Pane <>
Subject Re: [PATCH] remove some more strdup calls
Date Mon, 30 Jul 2001 03:52:20 GMT
Marc Slemko wrote:

>On Sun, 29 Jul 2001, Brian Pane wrote:
>>Here's another small performance patch to remove calls
>>to apr_pstrdup, this time in location_walk.
>erm... doesn't this change mean that we are mucking with r->uri directly
>by calling ap_no2slash() on it?  Isn't that a problem and the whole point
>behind the strdup?  r->uri should remain the original one, not the one 
>with whatever fixups we use for whatever reason...
Please forgive me if I'm just missing something obvious,
but why would leaving redundant slashes in r->uri be
considered a good thing?  It seems like this only makes
life more complicated for downstream code, because any
module that does transformations based on URI must
be prepared to deal with redundant slashes too.


View raw message