httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Harrie Hazewinkel <har...@lisanza.net>
Subject Re: [PATCH-concept] more dynamic configuration
Date Sun, 08 Jul 2001 00:14:19 GMT
dean gaudet wrote:
> 
> On Fri, 6 Jul 2001, Harrie Hazewinkel wrote:
> 
> > Attached is a patch that adds more dynamic configuration.
> > It places some of the MPM variables such as 'ap_max_daemons_limit',
> > 'ap_daemons_limit', 'ap_daemons_min_free' and 'ap_daemons_max_free'
> > in the scoreboard.
> 
> -1.
> 
> the concept is ok, but the implementation sucks.
> 
> you've just allowed arbitrary code to do such broken things as set
> ap_daemons_min_free to be greater than ap_daemons_max_free... or lots of
> other brokenness.

Hmm, I see what you mean. In my case I expected that to be done
in the management module itself. For instance, SNMP needs to test
it first if it would be allowed to make the change before it is
allowed to change.

> 
> a more correct approach would be to call functions supplied by the MPM to
> modify those parameters.

I already thought that an interface towards these variables
would be better. On top of that protection against inconsistent
values is good as well.

> 
> assuming the MPM you're referring to even has such a parameter ;)

Of course, that should be protected by that interfce.



Harrie
-- 
address: Covalent Technologies, 645 Howard St, San Francisco, CA - 94105
phone: +1-415-536-5221                               fax:+1-415-536-5210
personal website: http://www.lisanza.net/

Mime
View raw message