httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject [PATCH] threaded.c idle_spawn_rate gets huge relative to ap_daemons_limit
Date Wed, 25 Jul 2001 16:49:05 GMT
Even if child process creation is limited by ap_daemons_limit, we
still write trace messages saying we're about to spawn x children,
where x > ap_daemons_limit.

This patch doesn't let idle_spawn_rate get over ap_daemons_limit / 2.
It writes the log message at that threshold as well.

@@ -1030,7 +1032,7 @@
        }
        else {
 
-           if (idle_spawn_rate >= 8) {
+           if (idle_spawn_rate >= ap_daemons_limit / 2) {
                ap_log_error(APLOG_MARK, APLOG_NOERRNO|APLOG_INFO, 0, ap_server_conf,
                             "server seems busy, (you may need "
                             "to increase StartServers, ThreadsPerChild "
@@ -1048,7 +1050,8 @@
            if (hold_off_on_exponential_spawning) {
                --hold_off_on_exponential_spawning;
            }
-           else if (idle_spawn_rate < MAX_SPAWN_RATE) {
+           else if (idle_spawn_rate < MAX_SPAWN_RATE &&
+                     idle_spawn_rate * 2 < ap_daemons_limit) {
                idle_spawn_rate *= 2;
            }
        } 

-- 
Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...

Mime
View raw message